Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Let Button pass loosen constraints to it's child. #1040

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

fischerscode
Copy link
Contributor

This PR fixes #1039.

I've replaced the Column with a Center. By setting the factors to 1, I've prevented Center from expanding.
With this change, Button will satisfy the constraints with a minimal size. The constraints passed to the child are loosen. Therefor, the child's size can also be to small. This will result in a centered child.

Close #1039

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@bdlukaa bdlukaa merged commit 1e5e9c8 into bdlukaa:master Apr 8, 2024
2 of 3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 A child of Button has an unbound height constraint.
2 participants