Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Right to Left support #184

Merged
merged 16 commits into from
Feb 17, 2022
Merged

Right to Left support #184

merged 16 commits into from
Feb 17, 2022

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Feb 16, 2022

Fixes #181

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

@bdlukaa bdlukaa requested a review from WinXaito February 16, 2022 00:10
@WinXaito
Copy link
Collaborator

Does this is expected ? (the ? char at the left)

image


image


Wrong icon or wrong movement, but it's not clear

image


This is maybe OK like that, but...

image

image


I think that's come from Flutter, but I'm pretty sure that's not what is expected:

image
image
image

@WinXaito
Copy link
Collaborator

I haven't looked at the code yet.

Btw: it's a really weird effect

@bdlukaa
Copy link
Owner Author

bdlukaa commented Feb 17, 2022

Does this is expected ? (the ? char at the left)

Idk, but ig it is.

@bdlukaa bdlukaa merged commit efcfb2f into master Feb 17, 2022
@bdlukaa bdlukaa deleted the rtl branch February 17, 2022 18:12
@henry2man henry2man mentioned this pull request Mar 5, 2022
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right to Left support
2 participants