Expander header's height determination #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was achieved by encasing the content widget in a Flexible widget so the Column can size the header as per its children's requirements. |
bdlukaa
requested changes
Sep 10, 2022
Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
|
Expander padding is off
|
In latest commit, padding has been added to Container widget responsible for header. |
bdlukaa
requested changes
Sep 13, 2022
|
The trailing is being constrained down, for some reason
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The height of Expander's header is now determined based on the height of its children.
Pre-launch Checklist
CHANGELOG.mdwith my changes