NavigationView: Make compatible the use of PaneItems and content attribute again #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I don't know if I like the idea of having 3 different ways to assign the view content. Maybe we could talk more about this in discord |
|
If #607 goes ahead this could be closed. |
|
@henry2man I'd like your review on #607 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
PaneItems"body" attribute not longer required and compatible withcontentattribute. Related with #531 (comment) (TL;DR: we want to useLazyIndexedStackincontentin order to have state preservation whenPaneItemis changed)Pre-launch Checklist
CHANGELOG.mdwith my changes