-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix tab view wheel scroll #772
Conversation
The |
Not necessary, if a user want to keep the vertical scroll over all page he can. But I think we must put the default value to true. What do you think about that ? And if you really want to remove it, I think it’s preferable to set it to true by default and mark as deprecated to avoid a breaking change and remove it in v5.0.0 Edit: BTW I understand why you said that, I don’t see that I don’t use this property anymore. I will do a correction to use that property with a default value to true if you agree with that ;) |
Sounds fine to me! I checked on native and it stops the vertical scrolling, so I think we should do the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing because we make use of the property on the example app
👍 that must be good now |
Pre-launch Checklist
CHANGELOG.md
with my changes