Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix tab view wheel scroll #772

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Fix tab view wheel scroll #772

merged 5 commits into from
Mar 22, 2023

Conversation

WinXaito
Copy link
Collaborator

@WinXaito WinXaito commented Mar 15, 2023

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@WinXaito WinXaito requested a review from bdlukaa March 15, 2023 19:52
@bdlukaa
Copy link
Owner

bdlukaa commented Mar 17, 2023

The wheelScroll property can then be removed, right?

@WinXaito
Copy link
Collaborator Author

WinXaito commented Mar 17, 2023

The wheelScroll property can then be removed, right?

Not necessary, if a user want to keep the vertical scroll over all page he can.

But I think we must put the default value to true.

What do you think about that ? And if you really want to remove it, I think it’s preferable to set it to true by default and mark as deprecated to avoid a breaking change and remove it in v5.0.0

Edit: BTW I understand why you said that, I don’t see that I don’t use this property anymore. I will do a correction to use that property with a default value to true if you agree with that ;)

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 18, 2023

And if you really want to remove it, I think it’s preferable to set it to true by default and mark as deprecated to avoid a breaking change and remove it in v5.0.0

Sounds fine to me! I checked on native and it stops the vertical scrolling, so I think we should do the same.

Copy link
Owner

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because we make use of the property on the example app

@WinXaito
Copy link
Collaborator Author

👍 that must be good now

@bdlukaa bdlukaa merged commit 8f12b47 into bdlukaa:master Mar 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants