Fix compilation on Flutter 3.13.0 stable #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, analysis fails due to ignoringSemantics being deprecated. However I can't seem to find the equivalent of the current implementation... I don't think |
ricardoboss
approved these changes
Aug 17, 2023
bdlukaa
reviewed
Aug 17, 2023
Additionally add PR mention to CHANGELOG.md
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (rudimentarily) fixes compilation on Flutter 3.13.0 stable. I tested running the example on Windows, it runs and I haven't found anything broken yet.
However, as the breaking changed APIs were not documented (here or here) and knowing my knowledge of both Fluent UI's and Flutter's internals is limited, these changes might not be the correct...
Pre-launch Checklist
CHANGELOG.mdwith my changes