Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing actions for home key #94

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

bdraco
Copy link
Owner

@bdraco bdraco commented Feb 9, 2024

Homekey actions where being ignored since they didn't have a mapping.
We have these locks listed as supported so they should work

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2dd2f23) 95.70% compared to head (afb47a1) 95.66%.

❗ Current head afb47a1 differs from pull request most recent head b4afc5c. Consider uploading reports for the commit b4afc5c to get more accurate results

Files Patch % Lines
yalexs/backports/functools.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   95.70%   95.66%   -0.05%     
==========================================
  Files          29       29              
  Lines        3376     3389      +13     
==========================================
+ Hits         3231     3242      +11     
- Misses        145      147       +2     
Flag Coverage Δ
unittests 95.66% <84.61%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 83e6df7 into master Feb 9, 2024
12 checks passed
@bdraco bdraco deleted the more_missing_lock_actions branch February 9, 2024 19:27
abjorck pushed a commit to abjorck/yalexs that referenced this pull request Feb 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant