Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't create activity from lock status polls #95

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

abjorck
Copy link
Contributor

@abjorck abjorck commented Feb 15, 2024

Using the Yale app causes locks to send status updates twice a minute, which would trigger the hass integration to look for new activities.
Drop these message to reduce api calls

@abjorck abjorck force-pushed the ignore-lock-status2 branch from aa8467a to 692fee4 Compare February 15, 2024 19:59
@abjorck abjorck force-pushed the ignore-lock-status2 branch from 692fee4 to 1d3ae75 Compare February 15, 2024 20:33
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a68e17) 95.71% compared to head (1d3ae75) 95.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   95.71%   95.72%           
=======================================
  Files          29       29           
  Lines        3387     3392    +5     
=======================================
+ Hits         3242     3247    +5     
  Misses        145      145           
Flag Coverage Δ
unittests 95.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abjorck
Copy link
Contributor Author

abjorck commented Feb 15, 2024

so there was some inital clash with the bridge offline status.. nice that there was a test to catch me breaking that. added some more fields to compare..

@bdraco
Copy link
Owner

bdraco commented Feb 15, 2024

I'll try this later today when I get back home

@bdraco
Copy link
Owner

bdraco commented Feb 16, 2024

Going to let it run overnight to make sure there’s no side effects and all my automations don’t fail

@abjorck
Copy link
Contributor Author

abjorck commented Feb 21, 2024

How did it go? Any thoughts?

@bdraco
Copy link
Owner

bdraco commented Feb 23, 2024

Nothing blew up. I'm going to put it on my other larger system now

@bdraco
Copy link
Owner

bdraco commented Feb 25, 2024

Seems fine on the other system as well.

@bdraco bdraco merged commit 289da40 into bdraco:master Feb 25, 2024
8 checks passed
@bdraco
Copy link
Owner

bdraco commented Feb 25, 2024

Thanks @abjorck

@bdraco
Copy link
Owner

bdraco commented Feb 25, 2024

Published 1.11.3

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants