Tighten int(/long) and float encodable? checks #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydog187
approved these changes
Dec 17, 2022
|
@LostKobrakai can you rebase with the latest? |
LostKobrakai
force-pushed
the
pr/tighten-int-and-float-encodable-checks
branch
from
014c2e4 to
e25d34c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were what made the property test (#78) fail, as it would try to encode values not encodable as int/float in unions having int/float before long/double. This will also make sure the library won't consider integers not fitting into a 64bit long field to be encodable.