Validate injector cache saved and optimize local cache selection #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 1.x #417 +/- ##
=========================================
Coverage 99.87% 99.87%
Complexity 243 243
=========================================
Files 54 54
Lines 814 816 +2
=========================================
+ Hits 813 815 +2
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
koriym
changed the title
|
ray-di/Ray.PsrCacheModule#17 で Ray.PsrCacheModule のリリースを行った後にcomposer.jsonを修正します。 |
src/Injector.php
Outdated
| @@ -26,7 +25,7 @@ public static function getInstance(string $appName, string $context, string $app | |||
| { | |||
| $meta = new Meta($appName, $context, $appDir); | |||
| $cacheNamespace = str_replace('/', '_', $appDir) . $context; | |||
| $cache ??= ApcuAdapter::isSupported() ? new ApcuAdapter($cacheNamespace) : new FilesystemAdapter('', 0, $meta->tmpDir . '/injector'); | |||
| $cache = (new LocalCacheProvider($meta->tmpDir . '/injector', $cacheNamespace))->get(); | |||
There was a problem hiding this comment.
受け取った $cache の値に関わらず LocalCacheProvider の値に置き換えてしまっていますかね？
NaokiTsuchiya
approved these changes
Apr 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfonyはキャッシュが失敗したときにLogに記録して
https://github.com/symfony/cache/blob/v5.4.22/Traits/AbstractAdapterTrait.php#L230
その後trigger_errorでエラー発生させますが、
@で抑制されていてエラーハンドラーで検出しないとユーザーが気がつきません。https://github.com/symfony/cache/blob/v5.4.22/CacheItem.php#L189
このPRはキャッシュの検証を行い、検出可能にします。
それに加え、ローカルキャッシュの判定を修正し、CLIのときにApcuAdapterを使わないようにしました。
27c7d8e
Symfony logs cache failures to
https://github.com/symfony/cache/blob/v5.4.22/Traits/AbstractAdapterTrait.php#L230
It then raises an error with trigger_error, but it is suppressed with
@and the user will not notice it unless it is detected by the error handler.https://github.com/symfony/cache/blob/v5.4.22/CacheItem.php#L189
This PR validates the cache and makes it detectable.