Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support monolog v3 #421

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Support monolog v3 #421

merged 2 commits into from
Aug 30, 2023

Conversation

koriym
Copy link
Member

@koriym koriym commented Aug 29, 2023 •
edited
Loading

  • monolog v3サポート
  • monolog v3のサポートがないと最新版がインストールできないライブラリ（google/apiclient)がインストール可能になります。

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa11420) 100.00% compared to head (ae0189e) 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##                 1.x      #421   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       242       242           
===========================================
  Files             54        54           
  Lines            812       812           
===========================================
  Hits             812       812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koriym koriym requested a review from NaokiTsuchiya August 29, 2023 10:07
@koriym koriym marked this pull request as ready for review August 29, 2023 10:08
koriym
koriym commented Aug 30, 2023
View reviewed changes
src/Provide/Error/ErrorLogger.php
@@ -22,12 +21,29 @@ public function __construct(

public function __invoke(Throwable $e, RouterMatch $request): string
{
$level = $e->getCode() >= 500 ? Logger::ERROR : Logger::DEBUG;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger::ERROR がv3でdeprecateになり、そもそもMonolog定数に依存しないようにしました。
per/loggerがログレベルの定数を持ってますが、Monologとの互換性がありません。

@koriym koriym merged commit 0f2e277 into 1.x Aug 30, 2023
@koriym koriym deleted the monolog_v3 branch August 30, 2023 21:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NaokiTsuchiya NaokiTsuchiya NaokiTsuchiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koriym @NaokiTsuchiya