Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

json_encode to have a string expression #253

Merged
merged 3 commits into from
Nov 14, 2021

Conversation

koriym
Copy link
Member

@koriym koriym commented Nov 14, 2021

Closes #252

@koriym koriym added Bug and removed Bug labels Nov 14, 2021
@koriym koriym force-pushed the fix-json-schema-interceptor branch from f13b1e1 to 801a975 Compare November 14, 2021 02:53
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #253 (5af43a6) into 1.x (53c2c4b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5af43a6 differs from pull request most recent head a2a09fc. Consider uploading reports for the commit a2a09fc to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##                 1.x      #253   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       510       510           
===========================================
  Files             83        83           
  Lines           1308      1308           
===========================================
  Hits            1308      1308           
Impacted Files Coverage Δ
src/AbstractRequest.php 100.00% <ø> (ø)
...c/JsonSchema/Interceptor/JsonSchemaInterceptor.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c2c4b...a2a09fc. Read the comment docs.

@koriym koriym force-pushed the fix-json-schema-interceptor branch from 5af43a6 to a2a09fc Compare November 14, 2021 11:34
@koriym koriym merged commit 55bd315 into bearsunday:1.x Nov 14, 2021
@koriym koriym deleted the fix-json-schema-interceptor branch November 14, 2021 11:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError : BEAR\Resource\Interceptor\JsonSchemaInterceptor::deepArray():
1 participant