Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Regex from sshGit #174

Closed
bee-san opened this issue Oct 5, 2021 · 2 comments · Fixed by #179
Closed

Add Regex from sshGit #174

bee-san opened this issue Oct 5, 2021 · 2 comments · Fixed by #179
Assignees
@alfredtso
Labels
good first issue Good for newcomers hacktoberfest

Comments

@bee-san
Copy link
Owner

bee-san commented Oct 5, 2021

Sshgit has a bunch of regex we can use :)

https://github.com/eth0izzle/shhgit/blob/master/config.yaml

Follow our contributing guide here:
https://github.com/bee-san/pyWhat/wiki/Adding-your-own-Regex
@alfredtso
Copy link
Contributor

Can i try work on this ? thanks

@ghost ghost assigned alfredtso Oct 6, 2021
@bee-san
Copy link
Owner Author

bee-san commented Oct 6, 2021

Can i try work on this ? thanks

Go ahead!

@alfredtso alfredtso mentioned this issue Oct 7, 2021
Closed
alfredtso added a commit to alfredtso/pyWhat that referenced this issue Oct 7, 2021
@alfredtso
Add regex and tests for PEM formatted private key
56fde4b 
The regex will match private key generated by ssh-keygen and those
defined by OpenSSL header file. The regex, however, doesn't validate if
the string within BEGIN and END label is "correct" Base64 encoded. As it
can be validated be direct checking with the public key

Resolves: bee-san#174
@alfredtso alfredtso mentioned this issue Oct 7, 2021
Merged
alfredtso added a commit to alfredtso/pyWhat that referenced this issue Oct 8, 2021
@alfredtso
Add regex and tests for PEM formatted private key
b8420f2 
The regex will match private key generated by ssh-keygen and those
defined by OpenSSL header file. The regex, however, doesn't validate if
the string within BEGIN and END label is "correct" Base64 encoded. As it
can be validated be direct checking with the public key

Resolves: bee-san#174
alfredtso added a commit to alfredtso/pyWhat that referenced this issue Oct 8, 2021
@alfredtso
Add regex and tests for PEM formatted private key
6ae7cfe 
The regex will match private key generated by ssh-keygen and those
defined by OpenSSL header file. The regex, however, doesn't validate if
the string within BEGIN and END label is "correct" Base64 encoded. As it
can be validated be direct checking with the public key

Resolves: bee-san#174
bee-san pushed a commit that referenced this issue Oct 8, 2021
@alfredtso
Add regex and tests for PEM formatted private key (#179)
005516a 
The regex will match private key generated by ssh-keygen and those
defined by OpenSSL header file. The regex, however, doesn't validate if
the string within BEGIN and END label is "correct" Base64 encoded. As it
can be validated be direct checking with the public key

Resolves: #174
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alfredtso alfredtso

Labels
good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
2 participants
@bee-san @alfredtso