Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve printing #207

Merged
5 commits merged into from
Oct 12, 2021
Merged

Improve printing #207

5 commits merged into from
Oct 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2021

⚠ Pull Requests not made with this template will be automatically closed 🔥

Prerequisites

Why do we need this pull request?

Currently, pywhat does not print tags and it's output cannot be customized.

What GitHub issues does this fix?

Copy / paste of output

Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:

$ pywhat --format '%n - %m' user@mail.com
Uniform Resource Locator (URL) - mail.com
Email Address - user@mail.com

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #207 (c173aae) into main (4ac82e6) will increase coverage by 2.18%.
The diff coverage is 98.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   92.27%   94.46%   +2.18%     
==========================================
  Files          14       14              
  Lines        1644     1715      +71     
==========================================
+ Hits         1517     1620     +103     
+ Misses        127       95      -32     
Impacted Files Coverage Δ
pywhat/printer.py 77.37% <94.44%> (+36.98%) ⬆️
pywhat/what.py 81.72% <100.00%> (+1.72%) ⬆️
tests/test_click.py 98.31% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac82e6...c173aae. Read the comment docs.

@ghost ghost merged commit e8aaaaa into main Oct 12, 2021
@ghost ghost deleted the improve-printing branch October 12, 2021 20:32
This pull request was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI should print rarity and tags of entry
3 participants