Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add DOI support #219

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Add DOI support #219

merged 2 commits into from
Oct 22, 2021

Conversation

spicyyboi
Copy link
Contributor

@spicyyboi spicyyboi commented Oct 20, 2021

⚠ Pull Requests not made with this template will be automatically closed 🔥

Prerequisites

Why do we need this pull request?

This adds the support for DOIs (digital object identifiers). DOIs are a standardized way to resolve documents. You can learn more about them here.

Copy / paste of output

Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:

> what doi:10.1000/123
Matched on: doi:10.1000/123
Name: Digital Object Identifier (DOI)
> what https://doi.org/10.1000/123
Matched on: https://doi.org/10.1000/123
Name: Digital Object Identifier (DOI)

Matched on: https://doi.org/10.1000/123
Name: Uniform Resource Locator (URL)

@bee-san
Copy link
Owner

bee-san commented Oct 22, 2021

Copy / paste of output

Please show full output :)

@spicyyboi
Copy link
Contributor Author

Sure! I've edited the comment to add the command signature and also added another example.

@bee-san
Copy link
Owner

bee-san commented Oct 22, 2021

Thanks so much!! I ask for full output so I can see if there's any false positives :) <3

@bee-san bee-san enabled auto-merge October 22, 2021 09:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #219 (cb319bc) into main (ec34001) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   92.52%   92.55%   +0.03%     
==========================================
  Files          14       14              
  Lines        1204     1209       +5     
==========================================
+ Hits         1114     1119       +5     
  Misses         90       90              
Impacted Files Coverage Δ
tests/test_click.py 98.34% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec34001...cb319bc. Read the comment docs.

@bee-san bee-san merged commit e9bf98c into bee-san:main Oct 22, 2021
@spicyyboi spicyyboi deleted the doi branch October 25, 2021 16:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants