-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add unix timestamp support #85
Conversation
|
@amadejpapez @piatrashkakanstantinass what do you think of the rarity here? |
There's another caveat here that timestamps < |
I would use 0.5 here. |
@Granitosaurus thanks for the heads up! We'll add it to the tech-debt register (when I make one!) and when we introduce cooler checks we can do stuff like this :) I think the checks are a github issue somewhere 😓 |
reduced rarity to 0.5 as recommended. |
Merge conflicts! :( |
@Granitosaurus merge conflicts 😢 |
Should be good to go now |
Hello,
for my first contributions I've picked something simple: unix epoch timestamps:
and milliseconds:
I think it would be great to support non-regex identifiers as this could have been done much more gracefully in python with
datetime
module. Nevertheless here's regex based implementation! :)