Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Dockerfile to change deprecated links #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josh-nook
Copy link
Contributor

Old dockerfile didn't compose due to deprecated packages and broken links.

@IgWod
Copy link
Collaborator

IgWod commented Oct 7, 2024

Hey @josh-nook,

Thank you for your contribution. Looks good to me. Just to double check, did you try to run a simple program with MAMBO inside the container just to confirm there aren't any issues because of the newer software?

@josh-nook
Copy link
Contributor Author

It worked in the aarch64 VM, reminds me that I didn't try the riscv. I'll do that now and get back to you

@josh-nook
Copy link
Contributor Author

Unfortunately,

MAMBO: detected architecture "riscv64"
make[2]: *** No rule to make target 'native'.  Stop.
make[1]: *** [makefile:79: pie] Error 2
make: *** [makefile:76: all] Error 2

When following the /docker/readme instructions for riscv

@IgWod
Copy link
Collaborator

IgWod commented Oct 8, 2024

I can't currently run the image, but I had a brief look at the build instructions and they aren't correct anymore:

This:

Clone MAMBO using the following command: git clone --recurse-submodules https://github.com/beehive-lab/mambo.git

Should change to:

Clone MAMBO using the following command: git clone https://github.com/beehive-lab/mambo.git

And this can be completely removed as now it is all in one repo on master:

Run the following commands: cd pie && git checkout master && cd .. && git checkout riscv

Could try it and if it works update the instruction?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants