#172 - refactor request table #233
Conversation
|
Conflicts with main |
Its still in draft - not quite done yet :) I'll make sure they are taken care of before I move it out of draft |
src/components/SyncUserModal.tsx
Outdated
| @@ -146,7 +146,7 @@ const SyncUserModal = ({ open, setOpen }: ModalProps) => { | |||
| .catch((e) => { | |||
| setAlert({ | |||
| severity: 'error', | |||
| message: e, | |||
| message: e.response.data.message, | |||
There was a problem hiding this comment.
response is optional in AxiosError, so maybe something like
message: e.response?.data.message ?? e.toJSON()There was a problem hiding this comment.
There is e.response.data.message || e everywhere else I just overlooked it for this PR for some reason 🙃
src/hooks/useJobs.tsx
Outdated
| @@ -11,17 +11,17 @@ const useJobs = () => { | |||
| const { axiosManualOptions } = useMyAxios() | |||
| const [, execute] = useAxios({}, axiosManualOptions) | |||
|
|
|||
| const getJobs = () => { | |||
| const config: AxiosRequestConfig<Job[]> = { | |||
| const getJobs = (): Promise<AxiosResponse<Job[]>> => { | |||
There was a problem hiding this comment.
The parameterization of the AxiosRequestConfig was not wrong, but it bought us nothing. I like this a lot better, though if we wanted to be pedantic we could call this AxiosPromise<Job[]>, which also buys us nothing over what you have here ;)
There was a problem hiding this comment.
So I think that adding typing to AxiosRequestConfig actually types what is going to be in data in the options, which those two particular calls don't have any data so that is why I removed it. I had tried putting <Job> on the config for one of the other calls - maybe resume? - that returns a Job but accepts not a Job for data, and TypeScript errored on the typing. I didn't know there was an AxiosPromise type I had only seen the response type I will change it to the promise that looks a bit cleaner
Closes #172
Closes #96
Refactored request page to use the main table component. Was able to remove the file completely, as well as the Cache Service.