Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix duplicate database change event send on Library.add #5561

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

valrus
Copy link
Contributor

@valrus valrus commented Dec 26, 2024

Description

Fixes #5560. Also a couple other incidental changes / improvements:

  • Add EventType that holds the actual string literals used for event sending. With type checking, this can prevent subtle bugs resulting from misspelled event names.
  • Allow is_hidden to take str, and convert those str to Path. Without this fix, test_hidden.py was failing for me due to path.lstat()test_osx_hidden passes a str, and str doesn't have a lstat method.

To Do

  • Documentation.
  • Changelog.
  • Tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibModel.add sends database_change twice
1 participant