Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: writer support sort attr #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yywing
Copy link

@yywing yywing commented Dec 27, 2024

No description provided.

@yywing yywing force-pushed the write_support_sort branch from e0aa8a8 to 7dc34a2 Compare December 27, 2024 11:00
@beevik
Copy link
Owner

beevik commented Jan 17, 2025

While I can see the utility of this, I'm not comfortable with the way it modifies the document as a side effect of writing the XML. If all attributes are to be sorted across the board, then there should probably be some sort of Element API to do it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants