Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add build for openSUSE to app-build-verify #81

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jan 12, 2024

Changes

  • Builds Linux System project for openSUSE Tumbleweed alongside the other supported distros

Briefcase-Repo: https://github.com/rmartin16/briefcase
Briefcase-Ref: opensuse-pkg

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review January 12, 2024 20:18
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks fine; 👍 to that.

CI is failing a couple of tests - but if I'm reading it right, this an expected chicken-and-egg problem. This PR needs to point at the Briefcase OpenSuSE branch so that SuSE builds will complete, but that means the install tests fail version checks; but we need this PR in place before we can CI check the Open SuSE branch.

Have I got that right? We either need to accept these CI failures, or merge the OpenSuSE branch with no CI check? I'm fine with either - I just wanted to make sure I haven't missed something.

@rmartin16
Copy link
Member Author

The change itself looks fine; 👍 to that.

CI is failing a couple of tests - but if I'm reading it right, this an expected chicken-and-egg problem. This PR needs to point at the Briefcase OpenSuSE branch so that SuSE builds will complete, but that means the install tests fail version checks; but we need this PR in place before we can CI check the Open SuSE branch.

Have I got that right? We either need to accept these CI failures, or merge the OpenSuSE branch with no CI check? I'm fine with either - I just wanted to make sure I haven't missed something.

That's correct. And the Verify Briefcase jobs are failing because they bypass Briefcase-Repo and Briefcase-Ref altogether...

@freakboy3742 freakboy3742 merged commit 68f78e3 into beeware:main Jan 13, 2024
62 of 68 checks passed
@rmartin16 rmartin16 deleted the app-build-opensuse branch January 13, 2024 00:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants