-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bump actions/cache from 3.3.3 to 4.0.0 #85
Bump actions/cache from 3.3.3 to 4.0.0 #85
Conversation
Bumps [actions/cache](https://github.com/actions/cache) from 3.3.3 to 4.0.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.3.3...v4.0.0) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
hmmm:
If the cache can update itself now, this obviates the need to include the date in the cache key anymore. |
Good catch - I don't think I would have drawn that conclusion from reading the release notes, but AFAICT, you're right. I've made that change, and flagged you for an approval in case I've fat-fingered something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually....this new option doesn't quite do what it sounds like. By save-always
, it actually means: if the cache met the other qualifications to be saved, then also save even when the workflow is marked as a failure.
Unfortunately, the cache is still not uploaded when the action downloaded an existing cache using the key.
I re-ran one of the jobs for this PR where you can see this is still the case and the implementation of save-always
bears this out.
We're probably looking for resolution of actions/cache#1208 to fix this for us.
Well blargh. I guess I'll roll back my addition, and hang around for the other fix, then. |
e112fbf
to
b511b44
Compare
Bumps actions/cache from 3.3.3 to 4.0.0.
Release notes
Sourced from actions/cache's releases.
Changelog
Sourced from actions/cache's changelog.
Commits
13aacd8
Merge pull request #1242 from to-s/main53b35c5
Merge branch 'main' into main65b8989
Merge pull request #1284 from takost/update-to-node-20d0be34d
Fix dist66cf064
Merge branch 'main' into update-to-node-201326563
Merge branch 'main' into maine718767
Fix format0122982
Apply workaround for earlyExit3185ecf
Update "only-" actions to node2025618a0
Bump versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)