Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump actions/cache from 3.3.3 to 4.0.0 #85

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 21, 2024

Bumps actions/cache from 3.3.3 to 4.0.0.

Release notes

Sourced from actions/cache's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/cache@v3...v4.0.0

Changelog

Sourced from actions/cache's changelog.

3.3.3

  • Updates @​actions/cache to v3.2.3 to fix accidental mutated path arguments to getCacheVersion actions/toolkit#1378
  • Additional audit fixes of npm package(s)

4.0.0

  • Updated minimum runner version support from node 12 -> node 20
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/cache](https://github.com/actions/cache) from 3.3.3 to 4.0.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.3.3...v4.0.0)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 21, 2024
@rmartin16
Copy link
Member

hmmm:

If the cache can update itself now, this obviates the need to include the date in the cache key anymore.

@freakboy3742
Copy link
Member

If the cache can update itself now, this obviates the need to include the date in the cache key anymore.

Good catch - I don't think I would have drawn that conclusion from reading the release notes, but AFAICT, you're right. I've made that change, and flagged you for an approval in case I've fat-fingered something.

Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually....this new option doesn't quite do what it sounds like. By save-always, it actually means: if the cache met the other qualifications to be saved, then also save even when the workflow is marked as a failure.

Unfortunately, the cache is still not uploaded when the action downloaded an existing cache using the key.

I re-ran one of the jobs for this PR where you can see this is still the case and the implementation of save-always bears this out.

We're probably looking for resolution of actions/cache#1208 to fix this for us.

@freakboy3742
Copy link
Member

Actually....this new option doesn't quite do what it sounds like. By save-always, it actually means: if the cache met the other qualifications to be saved, then also save even when the workflow is marked as a failure.

Unfortunately, the cache is still not uploaded when the action downloaded an existing cache using the key.

Well blargh. I guess I'll roll back my addition, and hang around for the other fix, then.

@freakboy3742 freakboy3742 force-pushed the dependabot/github_actions/actions/cache-4.0.0 branch from e112fbf to b511b44 Compare January 25, 2024 03:22
@freakboy3742 freakboy3742 merged commit 4fa1cc9 into main Jan 25, 2024
136 of 138 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/cache-4.0.0 branch January 25, 2024 05:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants