Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add anydpi icon, plus simplified splash screens. #89

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add anydpi icon, plus simplified splash screens. #89

merged 1 commit into from
Apr 30, 2024

Conversation

freakboy3742
Copy link
Member

A big simplification of the icon and splash screen configuration for Android.

  • Adds an "adaptive" image variant. This appears to be necessary on recent versions (> API 25?) to get the icon on the launcher to render without the extra whitespace around the icon. The splash_background_color field has been adapted for use as the background of this icon.
  • Removes some unused launcher resources (drawable-v24/ic_launcher_foreground, drawable/ic_launcher_background) that appear to be unused leftovers from a default template.
  • Replaced the drawable-*/launch.png "made with beeware" image with a mipmap-*/splash.png image that is the same as the icon
  • Simplified the splash screen definition so that it doesn't need as many image variants.

The explicit splash screen is only used on very old Android versions (possibly only v7 and v7.1); more recent Androids use the adaptive icon variant. This splash screen is essentially just the app icon, centered on the launch page.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith mhsmith merged commit 1c55575 into main Apr 30, 2024
16 checks passed
@freakboy3742 freakboy3742 deleted the splash branch April 30, 2024 22:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants