Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Block pip 23.1 from use #1196

Merged
merged 3 commits into from
Apr 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ jobs:

- name: Install dev dependencies
run: |
python -m pip install --upgrade pip
# pip 23.1 has an issue with --user installs.
# See https://github.com/pypa/pip/issues/11982 for details
python -m pip install --upgrade "pip!=23.1"
python -m pip install --upgrade setuptools
# We don't actually want to install briefcase; we just want the dev
# extras so we have a known version of tox and coverage.
Expand Down Expand Up @@ -113,7 +115,9 @@ jobs:

- name: Install dev dependencies
run: |
python -m pip install --upgrade pip
# pip 23.1 has an issue with --user installs.
# See https://github.com/pypa/pip/issues/11982 for details
python -m pip install --upgrade "pip!=23.1"
python -m pip install --upgrade setuptools
# We don't actually want to install briefcase;
# we just want the dev extras so that we have a known version of coverage
Expand Down
1 change: 1 addition & 0 deletions changes/1195.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pip 23.1 was blocked from use due to pip bug #11982.
4 changes: 3 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ install_requires =
# the most recent version.
importlib_metadata >= 4.4; python_version <= "3.9"
packaging >= 22.0
pip >= 22
# pip 23.1 has an issue with --user installs.
# See https://github.com/pypa/pip/issues/11982 for details
pip >= 22, != 23.1
setuptools >= 60
wheel >= 0.37
build >= 0.10
Expand Down
5 changes: 5 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
passenv =
# LOCALAPPDATA is needed to test data directory creation on Windows.
LOCALAPPDATA
# pip 23.1 has an issue with --user installs.
# See https://github.com/pypa/pip/issues/11982 for details
# FIXME - remove this as soon as an updated pip is released.
setenv =
VIRTUALENV_PIP=23.0.1
extras =
dev
commands =
Expand Down