Fixes #420 - Ensure all libraries are fully deployed in AppImage. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppImages process all the dynamic libraries needed by an app, copying them into the AppImage, and re-writing any references to ensure that the AppImage is portable.
However, the default behavior of linuxdeploy is to only look in the
/usr/libfolder. Python dynamic modules will be in the Python folder, or in the app/app_packages folder.This modifies the call to linuxdeploy to provide the name of any other folder in the AppDir that contains a .so file, so that those files will also be marked for processing.
NOTE: This requires a very fresh version of linuxdeploy. If you've got a version of linuxdeploy from before 15 July, you'll get an error about the
--deploy-deps-onlyoption. To fix this, delete '~/.briefcase/tools/linuxdeploy-x86_64.AppImage` and re-run. #450 has been logged to provide an easier path for this.