Upgrade moshi #883
Open
Upgrade moshi #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-manes
approved these changes
Jul 30, 2024
|
@ben-manes This is odd, I cannot reproduce the ktlint error locally. |
jaredsburrows
force-pushed
the
pr/jaredsburrows/upgrade-moshi
branch
from
da74b85 to
28f5de5
Compare
|
I think it reproduced locally (before your last commit) ➜ gradle-versions-plugin git:(pr/jaredsburrows/upgrade-moshi) gradle build
executing gradlew instead of gradle
Downloading https://services.gradle.org/distributions/gradle-8.0.2-bin.zip
...........10%............20%............30%............40%............50%............60%...........70%............80%............90%............100%
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :gradle-versions-plugin:ktlintMainSourceSetCheck FAILED
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:2:16 Missing newline after "("
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:3:1 Unexpected indentation (4) (should be 2)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:4:1 Unexpected indentation (4) (should be 2)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:4:90 Missing newline before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:4:91 Missing trailing comma before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:25:61 A multiline expression should start on a new line
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:25:75 Missing newline after "("
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:25:75 Argument should be on a separate line (unless all arguments can fit a single line)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:26:1 Unexpected indentation (6) (should be 4)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:26:19 Argument should be on a separate line (unless all arguments can fit a single line)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:26:27 Missing newline before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:26:28 Missing newline before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:26:28 Missing trailing comma before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:28:44 A multiline expression should start on a new line
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:28:44 Newline expected before expression body
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:29:1 Unexpected indentation (6) (should be 4)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:30:1 Unexpected indentation (6) (should be 2)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:51:14 A multiline expression should start on a new line
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:51:56 Unexpected spacing after "("
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:59:30 Parameter should start on a newline
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:59:30 Missing newline after "("
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:59:30 Newline expected after opening parenthesis
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:1 Unexpected indentation (6) (should be 4)
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:7 Parameter should start on a newline
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:56 Missing newline before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:57 Missing newline before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:57 Newline expected before closing parenthesis
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:57 Missing trailing comma before ")"
/Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/generated/ksp/main/kotlin/com/github/benmanes/gradle/versions/updates/gradle/GradleUpdateChecker_Companion_VersionSiteJsonAdapter.kt:60:60 Unnecessary "Unit" return type
> Task :gradle-versions-plugin:compileKotlin
w: file:///Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/src/main/kotlin/com/github/benmanes/gradle/versions/updates/DependencyUpdatesTask.kt:127:66 Java type mismatch: inferred type is 'groovy.lang.Closure<*>', but 'groovy.lang.Closure<kotlin.Any!>' was expected.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':gradle-versions-plugin:ktlintMainSourceSetCheck'.
> A failure occurred while executing org.jlleitschuh.gradle.ktlint.worker.ConsoleReportWorkAction
> KtLint found code style violations. Please see the following reports:
- /Users/ben/projects/gradle-versions-plugin/gradle-versions-plugin/build/reports/ktlint/ktlintMainSourceSetCheck/ktlintMainSourceSetCheck.txt
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 40s
11 actionable tasks: 7 executed, 4 up-to-date |
jaredsburrows
force-pushed
the
pr/jaredsburrows/upgrade-moshi
branch
3 times, most recently
from
20f4ba0 to
2785736
Compare
jaredsburrows
force-pushed
the
pr/jaredsburrows/upgrade-moshi
branch
from
2785736 to
d350a85
Compare
|
@ben-manes Any reason why upgrading this causes the tests to fail? |
|
no clue. I would guess KSP is doing something weird to the byte code, but I've only used Kotlin for build scripts. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #835