Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix CME, update dependencies #927

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Fix CME, update dependencies #927

merged 3 commits into from
Jan 23, 2025

Conversation

elevenfive
Copy link
Contributor

@elevenfive elevenfive force-pushed the cme_fix branch 2 times, most recently from 08f7bc3 to bfcd791 Compare January 22, 2025 21:03
@jaredsburrows
Copy link
Collaborator

Can you remove all the upgrades in this PR?

  • The moshi one needs work - see open PRs.
  • The kotlin can be moved to another PR.
  • Remove gradle changes.

@elevenfive
Copy link
Contributor Author

thanks @jaredsburrows , done, please retrigger workflows

@jaredsburrows
Copy link
Collaborator

@elevenfive Also please remove the version changes, @ben-manes will do this on releases.

@jaredsburrows jaredsburrows requested review from jaredsburrows, sschuberth and ben-manes and removed request for sschuberth January 22, 2025 21:44
@ben-manes ben-manes merged commit 8456e86 into ben-manes:master Jan 23, 2025
2 checks passed
@ben-manes
Copy link
Owner

ben-manes commented Jan 23, 2025 •
edited
Loading

nevermind. The subproject had the plugin defined instead of just the root.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jaredsburrows jaredsburrows Awaiting requested review from jaredsburrows

@ben-manes ben-manes Awaiting requested review from ben-manes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elevenfive @jaredsburrows @ben-manes