Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ticket-id-complement input #31

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add ticket-id-complement input #31

merged 2 commits into from
Jan 10, 2025

Conversation

eversardoth
Copy link
Contributor

@eversardoth eversardoth commented Jan 7, 2025

Add ticket-id-complement input to avoid identical ticket_id value for parallel/matrix jobs in the same workflow run.

Motivation: Parallel/Matrix jobs could generate the same ticket_id, meaning multiple parallel jobs in the same workflow run could gain access to a resource at the same time. The new input allows adding a suffix to the ticket_id, allowing different values being generated for different jobs.

Resolves #32

…r parallel/matrix jobs in the same workflow run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • rootfs/scripts/lock.sh: Language not supported
Copy link
Owner

@ben-z ben-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice flexible solution! Just some minor suggestion on the naming and default value.

We don't yet have the infrastructure set up to test this. Did you try this manually and make sure it works?

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@eversardoth eversardoth requested a review from ben-z January 9, 2025 19:11
@ben-z
Copy link
Owner

ben-z commented Jan 10, 2025

LGTM! Thanks for the PR.

@ben-z ben-z merged commit 76ac16c into ben-z:main Jan 10, 2025
@ben-z
Copy link
Owner

ben-z commented Jan 10, 2025

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility of identical ticket_id for parallel/matrix jobs
2 participants