eng: Introduce flag to skip post-command hook BNCH-89430 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SongyuW
changed the title
CodesperYu
reviewed
Mar 19, 2024
|
|
||
| run "$PWD/hooks/post-command" | ||
| assert_output --partial ':bash: Processing' |
There was a problem hiding this comment.
for safety, would it make sense to add a refute that it's not skipping?
refute_output --partial 'SKIP_POST_COMMAND_HOOK flag Detected. Skipping...'
CodesperYu
approved these changes
Mar 19, 2024
kfbustam
approved these changes
Mar 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduce a new flag to completely skip post-command hook
Testing Done
Test PR: https://github.com/benchling/aurelia/pull/116898/files
The post hook command is skipped in the webpack cache with the flag set
https://buildkite.com/benchling/integration-tests/builds/275049#_
https://buildkite.com/benchling/monolith-tests/builds/420136#_
Prettier is unaffected without the flag update