Add initial Haskell support #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, we would love to use this, was there something blocking this from getting in? |
ktrz
reviewed
Mar 26, 2023
| @@ -25,6 +25,7 @@ This action currently supports the following tools: | |||
| - [BenchmarkTools.jl][] for Julia packages | |||
| - [Benchmark.Net][benchmarkdotnet] for .Net projects | |||
| - [benchmarkluau](https://github.com/Roblox/luau/tree/master/bench) for Luau projects | |||
| - [criterion](https://hackage.haskell.org/package/criterion) for Haskell projects | |||
There was a problem hiding this comment.
I am slightly confused by the naming. You're using criterion/cabal interchangeably. Which one is the correct one? Additionally, I would suggest adding haskel- prefix anyway just to make sure it's more obvious. So either haskell-cabal or haskel-criterion
| | .Net | [![C# Benchmark.Net Example Workflow][benchmarkdotnet-badge]][benchmarkdotnet-workflow-example] | [examples/benchmarkdotnet](./examples/benchmarkdotnet) | | ||
| | Luau | Coming soon | Coming soon | | ||
| | Haskell | | | |
There was a problem hiding this comment.
Can you add appropriate links here?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add Haskell support (only .csv output of
criterionpackage for now). I had some issues with passing the checks in my fork, so I would be happy to respond to some review (this is my first time dealing with Typescript or Javascript so I might have overlooked some important things)!