Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python 3.12 support #642

Merged
merged 21 commits into from
Oct 12, 2024
Merged

Python 3.12 support #642

merged 21 commits into from
Oct 12, 2024

Conversation

benfred
Copy link
Owner

@benfred benfred commented Nov 21, 2023

No description provided.

@benfred benfred marked this pull request as draft November 21, 2023 03:48
@benfred benfred mentioned this pull request Nov 21, 2023
@karolinepauls
Copy link
Contributor

I built this branch for our internal use and can confirm it works for us. A normal release build, I haven't tried static linking. I don't mind the line numbers. Thank you.

@walnutwaldo
Copy link

Built this for our internal use as well and it works

@psi29a
Copy link

psi29a commented Jun 25, 2024

Following :D

@paalka
Copy link

paalka commented Jun 29, 2024

In case it is useful to someone looking for a profiler with 3.12 support, austin is an alternative to py-spy with similar features and low overhead :)

Austin also uses a similar approach to py-spy in order to get the state of the GIL, which I think might be one of the pieces that is missing in order to fully support python 3.12 in py-spy.

@benfred benfred marked this pull request as ready for review October 10, 2024 18:51
@jiangliu
Copy link
Contributor

Look forward to get this work merged:)

@benfred
Copy link
Owner Author

benfred commented Oct 12, 2024

This doesn't handle the GIL detection yet - but I think this is worth merging anyways.

I've created #692 to track the GIL detection issue

@benfred benfred merged commit 4eb8cd2 into master Oct 12, 2024
70 checks passed
@benfred benfred deleted the python_3_12 branch October 12, 2024 04:21
This was referenced Oct 15, 2024
@tugtugtug
Copy link

This is great news and nice work! @benfred when will we have a release build that supports 3.12?

@benfred
Copy link
Owner Author

benfred commented Oct 30, 2024

GIL support is handled by #713 -

@tugtugtug I've created #714 to track the new release. If you're interested in testing the current state of things, you can download the built wheels from any CI run like https://github.com/benfred/py-spy/actions/runs/11600917374#artifacts

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants