Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test macos py3.11 #710

Merged
merged 6 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,6 @@ jobs:
os: [ubuntu-20.04, macos-13]
# some versions of python can't be tested on GHA with osx because of SIP:
exclude:
- os: macos-13
python-version: 3.11.0
- os: macos-13
python-version: 3.11.10
- os: macos-13
Expand Down
4 changes: 2 additions & 2 deletions ci/update_python_test_versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


def parse_version(v):
return tuple(int(part) for part in re.split("\W", v)[:3])
return tuple(int(part) for part in re.split(r"\W", v)[:3])


def get_github_python_versions():
Expand Down Expand Up @@ -82,7 +82,7 @@ def update_python_test_versions():
# since it currently fails in GHA on SIP errors
exclusions = []
for v in versions:
if v.startswith("3.11") or v.startswith("3.12"):
if v.startswith("3.11.10") or v.startswith("3.12"):
exclusions.append(" - os: macos-13\n")
exclusions.append(f" python-version: {v}\n")
first_exclude_line = lines.index(" exclude:\n", first_line)
Expand Down
3 changes: 2 additions & 1 deletion tests/integration_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def _sample_process(self, script_name, options=None, include_profile_name=False)
]
cmdline.extend(options or [])
cmdline.extend(["--", sys.executable, script_name])
subprocess.check_output(cmdline)
env = dict(os.environ, RUST_LOG="debug")
subprocess.check_output(cmdline, env=env)
with open(profile_file.name) as f:
profiles = json.load(f)

Expand Down
Loading