Skip to content

fix(Resize): Resize event didn’t trigger on scroll bar #40

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Sep 15, 2017

Watching for the window resize event meant that when you close a lightbox the width would not be calculated correctly leading to incorrect wrapping.

For reference see:

Here's a video of the issue we are seeing: https://screencast.com/t/WOrdVr9Sk

Watching for the window resize event meant that when you close a lightbox the width would not be calculated correctly leading to incorrect wrapping.
@SimeonC
Copy link
Contributor Author

SimeonC commented Sep 15, 2017

The tabbing of the JSX in the return statement is a little crazy, do you want me to fix it up or tab mine in different?

@benhowell
Copy link
Owner

Ah, nice catch! Thanks very much. I don't mind how the tabbing looks tbh so whatever you prefer is fine by me.

@SimeonC
Copy link
Contributor Author

SimeonC commented Sep 15, 2017

I'll leave it as is then, can't be bothered fixing it.

@benhowell benhowell merged commit 9c1d8de into benhowell:master Sep 15, 2017
@benhowell
Copy link
Owner

Included in v0.4.3 👍

@SimeonC
Copy link
Contributor Author

SimeonC commented Sep 15, 2017

Awesome, thanks.

@SimeonC SimeonC deleted the fix-resize-bug branch September 15, 2017 05:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants