Skip to content

Add cloneDeep for data #20

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scimonster
Copy link
Contributor

I found my app rerendering too often due to the data object changing as well. Plotly was adding uid keys to the traces.

@benjeffery
Copy link
Owner

Thanks for the PR, I'm a little wary of merging this as cloneDeep can be very expensive. I begrudgingly added it to layout as it tends to be limited in size - however data can be a very large object. Ideally fixing #6 properly should fix this. Putting this on hold for now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants