Custom metadata support -- merge conflicts resolved #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom metadata can now be added to options by storing an object on the `metadata` key of options with the key:value pairs of metadata. The keys will automatically have 'x-awz-meta-' added to them, so they should just have the name wanted for the metadata without the aws specific prefix.
The readme now documents the existance and usage of the options metadata field.
# Conflicts: # README.md # src/RNS3.js # src/S3Policy.js
Merge master into #1
|
Hi there. Any idea when this will be merged into master? I also need metadata support. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this in my own project but I think react-native-aws3 is a great module so I just wanted to make it a bit easier to merge #10.
Compared to #10 there's no changes in functionality but the merge conflicts that have been resolved.