Fixed issue with non-working unlock #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
The command
surepy locking -d <id> -m unlock
would not work (at least in my system). Because of theif lock_state:
in the CLI locking command method which always resolves to false when 0 (and 0 is the enum value of unlock).So the only change I suggest to fix this is to remove the
if lock_state:
condition completely - this condition is superfluous because the assignment block above makes sure that either lock_state has a reasonable value or returns otherwise. Another possibility would be to writeif lock_state in LockState:
which would make (doubly) sure that lock_state has a valid value.Best regards, Chris