Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Coins with 0 value are displayed despite having set minValueBtc #38

Open
gosuto-inzasheru opened this issue Jan 18, 2018 · 2 comments
Open

Comments

@gosuto-inzasheru
Copy link
Contributor

If I understand correctly, setting minValueBtc makes CryptoETF ignore coins which have a value under a certain threshold. Good for ignoring dust or coins with zero balance. Much like the "Hide 0 Balances" option on Poloniex' balance page.

However, I am doubting whether minValueBtc is doing what it says it does. The only time it is checked (as far as I can tell) is by updateHighestRankWithBalance(). This means that despite having minValueBtc set, coins with a value below minValueBtc are still displayed.

@benmarten
Copy link
Owner

Yes you're understanding is correct.
So basically right now the tool will keep track of the coin amount with the lowest rank > minValueBtc. E.g. if you own a fraction of a coin at rank 240, we commit that and only display the Top40 (if you own the 40. coin with more than minValueBtc).

I hope that makes sense to you... Happy to consider alternatives :)

@benmarten
Copy link
Owner

Actually please take a look at: https://github.com/benmarten/CryptoETF/blob/master/settings.example.json#L61

That should solve your issue. Setting this to true will hide all coins that you don't actually own.
Implemented in: #9

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants