--config doesn't work in GUNICORN_CMD_ARGS

[Code0x58]

Specifying --config in the GUNICORN_CMD_ARGS environment variable quietly fails as config file loading only happens when it is passed as an argument:

gunicorn/gunicorn/app/base.py

Lines 137 to 175 in 328e509

	def load_config(self):
	# parse console args
	parser = self.cfg.parser()
	args = parser.parse_args()
	# optional settings from apps
	cfg = self.init(parser, args, args.args)
	# Load up the any app specific configuration
	if cfg and cfg is not None:
	for k, v in cfg.items():
	self.cfg.set(k.lower(), v)
	if args.config:
	self.load_config_from_file(args.config)
	else:
	default_config = get_default_config_file()
	if default_config is not None:
	self.load_config_from_file(default_config)
	# Load up environment configuration
	env_vars = self.cfg.get_cmd_args_from_env()
	if env_vars:
	env_args = parser.parse_args(env_vars)
	for k, v in vars(env_args).items():
	if v is None:
	continue
	if k == "args":
	continue
	self.cfg.set(k.lower(), v)
	# Lastly, update the configuration with any command line
	# settings.
	for k, v in vars(args).items():
	if v is None:
	continue
	if k == "args":
	continue
	self.cfg.set(k.lower(), v)

[tilgovi]

It looks like we parse the command options from the environment only after loading from a config file. We would have to parse these first, to get the config file option.

Good find.

[benoitc]

yeah the env should probably checked first and then the rest. At least it's seems to be the common pattern. Would you mind to provide a PR for it?

[Code0x58]

Pull request #1581 submitted.