Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ADD ghcr.io image creation to workflow #409

Closed
wants to merge 2 commits into from

Conversation

rapejim
Copy link
Contributor

@rapejim rapejim commented Aug 4, 2024

Now with Github Container Registry (ghcr.io) too:

  • Added extract metadata step (for automated labels and tags of images)
  • Changed build&push step from a simple/manual "run" to official docker action.
    (All separated by branch selected)

@benzino77
Copy link
Owner

Could you please make this PR to development branch?
Why do we need another/additional registry?

@rapejim
Copy link
Contributor Author

rapejim commented Aug 5, 2024

Of course, I change it to the development branch.

Docker has limits for free accounts, for example the retention policy removes an image if no one pull/push it in 6 months. I know it's a long time, but I guess it also doesn't hurt to offer the additional Github registration which is also where the source code is, 😅.

@rapejim rapejim changed the base branch from master to development August 5, 2024 08:16
@rapejim
Copy link
Contributor Author

rapejim commented Aug 5, 2024

I have seen that I am doing the PR from my master branch, do you want me to change the source to development in my repository?

@benzino77
Copy link
Owner

I have seen that I am doing the PR from my master branch, do you want me to change the source to development in my repository?

I think that is a good idea.

@rapejim
Copy link
Contributor Author

rapejim commented Aug 8, 2024

I have seen that I am doing the PR from my master branch, do you want me to change the source to development in my repository?

I think that is a good idea.

Done, #410

@rapejim rapejim closed this Aug 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants