Remove NewStringFunc

It's not needed when you can just do logg.StringFunc(...).
bep · Aug 24, 2022 · ac765c2 · ac765c2
1 parent b188ee0
commit ac765c2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/example_test.go b/example_test.go
@@ -64,7 +64,7 @@ func Example_lazy_evaluation() {
 
 				}),
 		)
-		ctx.Log(logg.NewStringFunc(
+		ctx.Log(logg.StringFunc(
 			// This func will never be invoked with the current logger's level.
 			func() string {
 				return "log message: " + strings.Repeat("x", 9999)

diff --git a/logger.go b/logger.go
@@ -24,11 +24,6 @@ func (f StringFunc) String() string {
 	return f()
 }
 
-// NewStringFunc returns a StringFunc which implements Stringer.
-func NewStringFunc(f func() string) StringFunc {
-	return StringFunc(f)
-}
-
 func (s String) String() string {
 	return string(s)
 }

diff --git a/logger_test.go b/logger_test.go
@@ -195,7 +195,7 @@ func BenchmarkLogger_context_many_fields_duplicate_names_with_fields(b *testing.
 func BenchmarkLogger_levels(b *testing.B) {
 	doWork := func(l logg.LevelLogger) {
 		for i := 0; i < 10; i++ {
-			l.Log(logg.NewStringFunc(
+			l.Log(logg.StringFunc(
 				func() string {
 					return fmt.Sprintf("loging value %s and %s.", "value1", strings.Repeat("value2", i+1))
 				},