Fix stuck connection when another VPN app connects #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, as you might have realised @uoosef can't continue working on this project and as a result I've had to start maintaining them. I don't have strong a android development background so reviewing your changes is somewhat difficult for me. I will have to get a few people to look at these changes before I merge them. I hope you understand. ❤️ |
markpash
approved these changes
Feb 19, 2024
|
I had someone test this for me and it appears to work as intended. 👍 |
|
Dear Mark, Thank you for caring and maintaining the project, especially considering your limited experience in Android development. It means a lot <3 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18 and other scenarios where the connection is not stopped properly when it should.