Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Depend on React-Core instead of React #23

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Depend on React-Core instead of React #23

merged 2 commits into from
Sep 16, 2021

Conversation

samgreen
Copy link
Contributor

@samgreen samgreen commented Sep 15, 2021 •
edited
Loading

Context is here

nwadams
nwadams approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@nwadams nwadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@benbeltzer
Copy link
Contributor

lgtm, but are you planning to do the version bump in a separate PR?

@samgreen
Copy link
Contributor Author

Will do a separate PR yes, @benbeltzer

@samgreen samgreen merged commit 8ed41bb into main Sep 16, 2021
@samgreen samgreen deleted the depend_on_react_core branch September 16, 2021 17:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nwadams nwadams nwadams approved these changes

@benbeltzer benbeltzer Awaiting requested review from benbeltzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samgreen @benbeltzer @nwadams