Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolved issues of show motor_idle and motors Start inc header fields for BF 4.6 log files #797

Merged
merged 2 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2014,6 +2014,10 @@ <h5 class="modal-title-revision"></h5>
<label>D-Shot Offset %</label>
<input type="text" step="0.01" min="0" max="1" />
</td>
<td name="motor_idle">
<label>Motor idle %</label>
<input type="text" step="0.01" min="0" max="1" />
</td>
<td name="motorOutputLow">
<label>D-Shot Motor Low</label>
<input type="text" step="10" min="0" max="2047" />
Expand Down
1 change: 1 addition & 0 deletions src/flightlog_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,7 @@ export function FlightLogParser(logData) {
}
break;

case "motor_idle":
case "digitalIdleOffset":
that.sysConfig[fieldName] = parseInt(fieldValue, 10) / 100.0;

Expand Down
9 changes: 8 additions & 1 deletion src/header_dialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,12 @@ export function HeaderDialog(dialog, onSave) {
name: "digitalIdleOffset",
type: FIRMWARE_TYPE_BETAFLIGHT,
min: "3.1.0",
max: "4.5.1",
},
{
name: "motor_idle",
type: FIRMWARE_TYPE_BETAFLIGHT,
min: "4.6.0",
max: "999.9.9",
},
{
Expand Down Expand Up @@ -665,7 +671,7 @@ export function HeaderDialog(dialog, onSave) {
name: "dyn_idle_start_increase",
type: FIRMWARE_TYPE_BETAFLIGHT,
min: "4.5.0",
max: "999.9.9",
max: "4.5.1",
},
{
name: "dyn_idle_max_increase",
Expand Down Expand Up @@ -1783,6 +1789,7 @@ export function HeaderDialog(dialog, onSave) {
renderSelect("debug_mode", sysConfig.debug_mode, DEBUG_MODE);
setParameter("motorOutputLow", sysConfig.motorOutput[0], 0);
setParameter("motorOutputHigh", sysConfig.motorOutput[1], 0);
setParameter("motor_idle", sysConfig.motor_idle, 2);
setParameter("digitalIdleOffset", sysConfig.digitalIdleOffset, 2);
renderSelect(
"antiGravityMode",
Expand Down