Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Todo counter sample project #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alexluz321
Copy link

@alexluz321 alexluz321 commented Dec 12, 2024

This PR is for the implementation of the scenarios in the README.

How has this been tested?

The code has been tested manually and one unit test file has been added to test the TodoList, although the unit test does basic testing only.

Due to time constraints I couldn't add more unit tests, but I'll list some of the missing test scenarios I can think of:

  • TodoStatusBar
    • congrats banner is visible upon completion of all todos
    • banner doesn't appear on reload
    • banner doesn't appear in TodoFooter
  • TodoItem
    • todo is strikethrough when checked
    • todo is being persisted to backend
  • App
    • done counter is being updated

Some possible improvements to the code

  • Refactor backend calls out of App
  • Add pagination to TodoList
  • Create component for banner

https://bettermarks.atlassian.net/browse/BM-

@alexluz321 alexluz321 marked this pull request as ready for review December 12, 2024 19:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant