-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(deps): update dependencies #500
chore(deps): update dependencies #500
Conversation
- Use Quarkus BOM instead of universe as it's not needed - Remove use of CRD Generator from annotation processing as the SDK extension takes care of it now. Generated CRD is in a different spot now as it's generated when the controllers are processed so they are now found under operator/target/kubernetes - Had to change the super class of ResourceEvent because AbstractEvent got renamed to DefaultEvent but will re-introduce AbstractEvent in a new SDK release to revert backwards compatibility that shouldn't have been broken
Note that this is only needed if we provide a QuarkusApplication, otherwise the SDK will automatically do it.
df96614
to
e2f43b3
Compare
e2f43b3
to
3939d0c
Compare
The last issue seems to be with the quarkus generated Service in the sync kubernetes.yml. Instead of using port 8080, it's specifying port 80 - there's no change in our config nor mention of a property to control this. In any case when the Service is using port 80 the external LoadBalancer Service created to access the sync won't actually respond to requests. I've verified that if I manually update the kubernetes.yml to still use port 8080 it works as expected. Need to track down why this change was made in quarkus - asked as https://stackoverflow.com/questions/69122602/change-in-default-service-host-port |
Once we are comfortable with these changes, I have another commit ready to remove some of the tech debt. |
Tracked the port change down: quarkusio/quarkus#15407 |
CRD listing permission should be removed from CSV as well.
I'm see a local build error when compiling:
Anyone know what might cause this? Making changes like this resolves the compile error:
|
@k-wall you shouldn't be seeing errors. Seems like you are getting a different generator version. That said there's a lot of stuff in our builders that could be cleaned up. It looks like newX was used quite a bit with strings and the transitive building should work as expected with custom types. |
This is a Java version issue. If I use Java 11 (like CI), the problem goes away, if I use Java 14 or 16 (my default), I see the compilation error. |
Note that we haven't tested with Java 16 so good to know there might be issues with it. Java 17 support is on the roadmap once it's released. |
To fix the transitive stuff we need sundrio .5 or later - sundrio/sundrio#260 However that does not look to be working with this quarkus version, so I won't pursue that yet. |
Agreed. Let's merge this PR. |
Any additional changes will come as a separate pr. It will look something like https://github.com/shawkins/mk-agent/commit/7c706f05c68527fb7be414fb7597479df8dfe9bb |
So I tested these changes and found an NPE on the fleetshard operator that seems to be related to ConfigProperties and related things get deprecated in new Quarkus version. More details from @shawkins @MikeEdgar who are working on it. |
Use kubernetes extension properties to automatically generate the ServiceAccount and add `app` label to resources.
Signed-off-by: Michael Edgar <medgar@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
extension takes care of it now. Generated CRD is in a different spot
now as it's generated when the controllers are processed so they are
now found under operator/target/kubernetes
got renamed to DefaultEvent but will re-introduce AbstractEvent in a
new SDK release to revert backwards compatibility that shouldn't have
been broken