MGDSTRM-10039 elevating the priority of broker and zookeeper pods #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the direct install method however no longer works due to new references to classes not in this bundle
github-actions
bot
added
operator
|
I'm not sure what a good naming convention is here. We already have kas-fleetshard-high. I went with core, but you could also go with standard, moderate, medium high, etc. The choice of 10 for the priority value is also arbitrary. We can of course space that out more if desired - high is 1000000 |
MikeEdgar
approved these changes
Nov 3, 2022
|
Since "high" name already set precedent, I like the @shawkins idea of going with "standard, moderate, medium high, etc." then there is no ambiguity when referred in conjunction with other class types. |
rareddy
reviewed
Nov 7, 2022
|
|
||
| Kafka kafka = kafkaCluster.kafkaFrom(managedKafka, null); | ||
|
|
||
| assertEquals("kas-fleetshard-core", kafka.getSpec().getKafka().getTemplate().getPod().getPriorityClassName()); |
There was a problem hiding this comment.
I guess these need to be updated to new name to fix the unit tests
There was a problem hiding this comment.
Yes, sorry things were incomplete. Should be good now.
also slightly reducing the broker request to make evictions less common
|
Kudos, SonarCloud Quality Gate passed! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adding some trivial instance profiler changes.