Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bugfix: Correct IngressControllerManager handling of the http case #855

Merged
merged 1 commit into from
Jan 19, 2023
Merged

bugfix: Correct IngressControllerManager handling of the http case #855

merged 1 commit into from
Jan 19, 2023

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Jan 19, 2023 •
edited
Loading

This affected a kas-installer (development) use-case where kas-installer was installed from the add-on. It was erroneously adding an empty tls object in the HTTP case.

@github-actions github-actions bot added the operator changes related to operator label Jan 19, 2023
@k-wall k-wall added this to the 0.32.3 milestone Jan 19, 2023
@k-wall k-wall requested review from shawkins and grdryn January 19, 2023 11:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

shawkins
shawkins approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-wall k-wall merged commit 4cd22bb into bf2fc6cc711aee1a0c2a:main Jan 19, 2023
@k-wall k-wall deleted the icm-http branch January 19, 2023 14:13
biswassri pushed a commit that referenced this pull request Jan 19, 2023
@k-wall @biswassri
bugfix: Correct IngressControllerManager handling of the http case (#855
a1a2b7e 
)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shawkins shawkins shawkins approved these changes

@grdryn grdryn grdryn approved these changes

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.32.3
Development

Successfully merging this pull request may close these issues.
3 participants
@k-wall @grdryn @shawkins