Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

more completely addressing sonar complaints #887

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

shawkins
Copy link
Contributor

These were not completely addressed with the previous commit.

@shawkins shawkins requested review from MikeEdgar and biswassri March 23, 2023 15:31
@github-actions github-actions bot added the test Test related changes label Mar 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar added this to the 0.35.0 milestone Mar 23, 2023
Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawkins shawkins merged commit 34e1447 into bf2fc6cc711aee1a0c2a:main Mar 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Test related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants