Skip to content

Add Cuda Event #37

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 17, 2019
Merged

Add Cuda Event #37

merged 2 commits into from
May 17, 2019

Conversation

LutzCle
Copy link
Contributor

@LutzCle LutzCle commented May 9, 2019

This PR addresses issue #6.

@bheisler
Copy link
Owner

Hey, thanks for the pull request. It might be a few days before I can get a chance to review it in detail. In the meantime, I did notice that there aren't any tests for Stream::wait_event aside from the doctest - I think it might be possible to test it using Stream::add_callback as the asynchronous task. It wouldn't be a great test, but it would be something.

@bheisler bheisler merged commit b1727be into bheisler:master May 17, 2019
@bheisler
Copy link
Owner

Mostly looks good to me. It needs a few tweaks to the documentation but I can make those changes myself.

Thanks for the pull request!

@LutzCle
Copy link
Contributor Author

LutzCle commented May 17, 2019

Great, thanks! I'll be in touch with you about #38. I want to address your review when I find some free time.

@LutzCle LutzCle deleted the cuda-event branch June 4, 2019 15:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants