Add fuzzing, fix panics #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheisler
reviewed
Jul 14, 2022
|
Hey, thanks for the pull request. I'd never really considered fuzzing this code since the templates are typically compiled into the executable (ie. hopefully not attacker-controlled) and therefore not security-sensitive. These are problems that a regular user might run into though, so thanks for doing the legwork for me. In addition to the one request for a comment, could you add a couple of regular unit tests to demonstrate the erroneous cases the fuzzer found? Thanks! |
When closing a tag (block, or other), the search function did not
consider that the start and end tags can overlap in their symbols. It
also assumes a minimum length for the matching sequence based on a
complete start and complete end tag. These combined would cause range
errors by accessing the incorrect content such as:
{#}
// src/compiler.rs:58
comment = tag[2..1].trim()
This is fixed by skipping the start tag for the purpose of searching for
the end tag, assuming the start tag has equal with.
HeroicKatora
force-pushed
the
add-fuzzing
branch
from
144b8d1 to
7fb00ba
Compare
|
That should have addressed everything. Can you give it another review? |
|
Thanks for the pull request! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #23 but also fixes all panics found via such fuzzing. These are essentially already found in issues.
Closes: #22
Closes one other panic in malformed templates: An input ending in a literal with escape
\would reenter the parsing loop another time with empty input andescapedset, butconume_textassumes at least one byte to be present when escaped is set.